[IMP] stock_picking_package_info: duplicate moves on transfer #1242
Conversation
cubells
changed the title
|
Last changes were made by @agaldona but I do not have clear what was the issue why she changed it. |
|
@cubells @oihane No se si se podría plantear de otra forma. |
|
ya veo el problema. El usuario, si no aparecen las lineas, puede cancelar la reserva y volver a transferir, con lo cual, vuelven a aparecer todas las lineas. Tu método estaria bien si no añadiera todas las reservas de las lineas del picking a las operaciones otra vez, sino que pusiera la diferencia. En todo caso como está ahora es un problema grave porque añade lineas inexistentes al albarán. Si el encargado no se da cuenta, se facturarán lineas de más. Y eliminar las lineas cuando tienes 500 es imposible. Hoy no tengo tiempo, pero este fin de semana repaso a ver si puedo encontrar una solución óptima. |
|
Functionality tested on runbot 👍 |
|
Hi @cubells i created PR to your branch to fix travis related error. |
[8.0][stock_picking_package_info] Rebase. Fix lint error
|
Hi @cubells travis error related to other module. Not this module. Should we fix it on this PR? |
@oihane: There is a problem with method: create_all_move_packages
If picking lines are reserved, and picking operations exist, then this method duplicates moves because it adds the moves which quants are reserved to picking operations.
i.e.: If I have 1 line with 2 units of a product and check availability, then products are reserved and quants too with their lot_id.
If I click transfer button 2 lines operations are shown. If I remove lots because these lots are not correct, and click do_save_for_later button, picking operation lines are correct.
But when click again in transfer button, this method adds to the picking operations, 2 lines more due to quants reserved on picking line.
It's a problem because initial picking has 2 units and final picking has 4 units of product.
If this method don't create operations (the line I remove), then method do nothing.
I don't know in which cases It's necessary to change product_qty.